Disable staticcheck in golangci and add explicit staticcheck on different platforms with merge.#531
Open
martinkunc wants to merge 3 commits intomicrosoft:mainfrom
Open
Conversation
…rent platforms with merge.
Contributor
Author
|
@microsoft-github-policy-service agree |
|
@shueybubbles Can anyone please approve the Ci build, if it makes sense to you ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have noticed that some lint checks are filing in the repo. It looks it could be related to staticchecker using build tags.
I have attempted to disable the staticchecker in the PR pipeline and replace it with explicit run of staticchecker on different platforms as described in the link.
I am not sure if everything works right now, so creating just a draft PR for now.